Open AndersDJohnson opened 2 years ago
Thanks for your contribution. Could you rebase your PR?
@pastelsky Thanks, I have rebased. I left a few comments with some questions before we should proceed though. How can we test this well?
@AndersDJohnson Thanks! Note that we're in the middle of migrating our codebase to typescript, so I'm going to hold off this change for a while to prevent conflicts.
We don't have good tests for Bundlephobia (the UI / server) today, unfortunately — would love it if someone initiated a setup. Your changes rename variables only — so I think it should be safe as long as all usages are renamed.
Typescript should give us additional safety once that's merged.
Not sure yet if I applied these changes correctly, or if they will work properly, so would likely need help testing & reviewing.
But just thought I'd help start the process of considering a potential rename to more inclusive terms like blocklist and allowlist, as several other projects and teams are doing lately. If it's not feasible to take this on now, or there is disagreement, then these proposed changes can be dismissed.
For reference: