search

pastelsky / bundlephobia

🏋️ Find out the cost of adding a new frontend dependency to your project
https://bundlephobia.com
MIT License
9.02k stars 223 forks source link

chore: enable eslint #706

Closed darasus closed 2 years ago

darasus commented 2 years ago

Enable ESLint and fix errors

pastelsky commented 2 years ago

Thanks for submitting this change. We should also —

  1. Autofix ESLint errors using the current husky precommit hook
  2. Add ESLint checks to our CI (.github/workflows/ci.yml)
  3. Add a lint script to package.json
  4. Enable ESLint prettier (https://prettier.io/docs/en/integrating-with-linters.html) so formatting changes are linted as well.
darasus commented 2 years ago

@pastelsky I think all comments are taken care of. Mind having another look?

darasus commented 2 years ago

@pastelsky thanks for approving but i don't have permissions to merge.