search

pastelsky / bundlephobia

🏋️ Find out the cost of adding a new frontend dependency to your project
https://bundlephobia.com
MIT License
8.92k stars 221 forks source link

Kickoff TypeScript migration #708

Closed igordanchenko closed 1 year ago

igordanchenko commented 1 year ago

1) Add Typescript dependencies 2) Migrate blog pages and components to .tsx

darasus commented 1 year ago

@igordanchenko Based on my experience with PR reviews in this repository I'd suggest to keep scope of this PR to bare minimum. If you're integrating typescript then I would reset actual migration changes (maybe only keep it to a single file to validate that it's working fine).

igordanchenko commented 1 year ago

Type checking runs as part of yarn build - which is also executed in GitHub CI workflow.

Are you sure you want a separate script for this?

pastelsky commented 1 year ago

Gotcha! Good to go then.