search

pastorhudson / pcobot

PCO Bot is a bot that integrates with the Planning Center Online API. It's built on Will Bot.
MIT License
14 stars 12 forks source link

Help fixes #70

Closed pastorhudson closed 6 years ago

pastorhudson commented 6 years ago

When my pcobot responds it tells me to @cbc help but my will handle is set to @cbcbot.

Chalta commented 6 years ago

Temporarily addressed in Readme pull request here: https://github.com/pastorhudson/pcobot/pull/71

Better fix is to check for full name and use that if it exists.

Chalta commented 6 years ago

Did a little bit of testing and this is a problem with the slack IO adapter in the backend plugin.

https://github.com/Chalta/pcobot/blob/ea36ca209394bb9e3754c441678275c6a4e9f8cd/will/backends/io_adapters/slack.py#L85-L86

The bot always reports it's handle as self.me.handle. (True of all users) The code doesn't look for a full name.

self.me.id likewise is the alphanumeric ID of the user. Full name (self.me.name) isn't checked for.

Chalta commented 6 years ago

I've submitted this as a pull request to the skoczen repo as well.

https://github.com/skoczen/will/pull/377

Chalta commented 6 years ago

https://github.com/pastorhudson/pcobot/pull/74

Merged to dev.

pastorhudson commented 6 years ago

Merged to master