search

pastthepixels / InfiniteShooter

A simplistic shooter made with the Godot engine.
https://pastthepixels.itch.io/infiniteshooter
GNU General Public License v3.0
18 stars 3 forks source link

Add option to change speed of background movement & small changes in FPS Limit. #9

Closed Frizy13 closed 2 years ago

pastthepixels commented 2 years ago

Really nice work! This is totally awesome! One thing I don't know as of yet though is if it should be merged to stable because it's an accessibility thing and it may be desperately needed by some people who play the game. But I really don't know since it all depends on how much it's needed. If you don't mind me asking, what do you think?

pastthepixels commented 2 years ago

Also, apologies if my weird arrangement of branches ends up breaking something. I just hope everything goes smoothly.

Frizy13 commented 2 years ago

Really nice work! This is totally awesome! One thing I don't know as of yet though is if it should be merged to stable because it's an accessibility thing and it may be desperately needed by some people who play the game. But I really don't know since it all depends on how much it's needed. If you don't mind me asking, what do you think?

I think this new feature should be added to the feature-additions branch first, since this feature is unstable. When it is brought to a stable state, it can be merged into the stable branch. Or we can close this pull-request until I find and fix the remaining bugs. What do you think?

pastthepixels commented 2 years ago

Yeah, that sounds good. I think I might actually see if I can get this to its own branch so I can fix bugs from there and then see what branch to merge it in. I was thinking that the main branches (stable/feature-additions) are like essentially stable for the current release and then stable for the next release, and then what determines what goes in the next release have to do with if it's a serious feature addition. I mean, although this technically is a pretty important change, I think the fact that it isn't too much of a big change combined with the fact that it might actually be needed for accessibility reasons would mean I should best implement it for the next point release. But I'll get this on its own branch first.