pat / after_commit

A Ruby on Rails plugin to add an after_commit callback. This can be used to trigger things only after the entire transaction is complete.
MIT License
62 stars 32 forks source link

Allow inline after_commit do blocks <-> make ar_after_transaction obsolote #7

Closed grosser closed 11 years ago

grosser commented 12 years ago

I have a similar project (ar_after_transaction)[https://github.com/grosser/ar_after_transaction] that fixes the same problems, but also adds a after_transaction do block style callback, so users can e.g.

after_create :do_stuff, :oops

def do_stuff
  after_transaction do
    send_an_email # cannot be rolled back
  end
  comments.create(...) # will be rolled back
end

Is it possilbe to include this behavior -> id like to mark the project as obsolete and just link here.

pat commented 12 years ago

Hi Michael

That's currently not possible in after_commit, but if you want to fork and patch it, I'll happily merge it in.

Pat

On 04/10/2011, at 1:59 AM, Michael Grosser wrote:

I have a similar project (ar_after_transaction)[https://github.com/grosser/ar_after_transaction] that fixes the same problems, but also adds a after_transaction do block style callback, so users can e.g.

after_create :do_stuff, :oops

def do_stuff after_transaction do send_an_email # cannot be rolled back end comments.create(...) # will be rolled back end

Is it possilbe to include this behavior -> id like to mark the project as obsolete and just link here.

Reply to this email directly or view it on GitHub: https://github.com/freelancing-god/after_commit/issues/7