search

pat / combustion

Simple, elegant testing for Rails Engines
MIT License
707 stars 51 forks source link

Add support for ActiveStorage #103

Closed mikian closed 4 years ago

mikian commented 4 years ago

Tried to use this wonderful gem with Rails app that uses ActiveStorage and encountered issue where it was not configured. This PR adds simple support for ActiveStorage.

pat commented 4 years ago

Thanks for this :) I just rebased your PR locally (after fixing the build in master - Rubocop was out of date), and then made a couple of tweaks, so it's now all merged into master manually. If you could confirm the latest works for you by using the following in your Gemfile, that'd be great:

gem "combustion",
  :git    => "https://github.com/pat/combustion.git",
  :branch => "master",
  :ref    => "189e12bf25"

If it's working in your engine/railtie, then I'll get a new version released soon!

pat commented 4 years ago

(Closing this PR as the code's already manually merged, but please do keep the conversation going here!)