search

pat / combustion

Simple, elegant testing for Rails Engines
MIT License
707 stars 51 forks source link

Drop `git` in gemspec #111

Closed utkarsh2102 closed 3 years ago

utkarsh2102 commented 3 years ago

Hi @pat,

Thanks, again, for your wonderful work on this! 🚀 This PR drops the usage of git in gemspec, as discussed in #109.

removing git makes it easier to bundle up files that I hadn't meant to release (i.e. that I hadn't committed - experiments, in-progress features, etc).

The recent version(s) of bundler won't let you release your gem if you have uncommitted files, so now that risk is even lower! 😄

Closes: #109

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>

pat commented 3 years ago

Thank you for the commits and discussion, all greatly appreciated :)

utkarsh2102 commented 3 years ago

Likewise! Thanks, Pat! 😄

pat commented 3 years ago

Just published 1.3.1 which includes this PR - thank you again!

Also: I reviewed the published gem file and found it had a few things we don't need - so that'll be neatened up on the next release 😁

utkarsh2102 commented 3 years ago

Hi Pat,

Also: I reviewed the published gem file and found it had a few things we don't need - so that'll be neatened up on the next release 😁

Ooh, this is great! ❤️ Let me know how it goes when you try it for other gems as well! 😄