search

pat / combustion

Simple, elegant testing for Rails Engines
MIT License
707 stars 51 forks source link

Fix checking for #legacy_connection_handling #127

Closed palkan closed 2 years ago

palkan commented 2 years ago

The method has been removed: https://github.com/rails/rails/pull/44827

pat commented 2 years ago

Thanks for the PR @palkan - unfortunately this approach doesn't work (@jrochkind had tried it as well), though I let the specs run to double-check.

However, the fix for edge Rails isn't in a released gem version - I'm just remedying that now (once the build is green, I'll publish v1.3.6).

pat commented 2 years ago

… and published :) Hopefully that gets things working for you!

palkan commented 2 years ago

Awesome! Thanks)