search

pat / combustion

Simple, elegant testing for Rails Engines
MIT License
707 stars 51 forks source link

ActiveRecord::Base.clear_active_connections! is deprecated in current edge Rails 7.1 #130

Closed jrochkind closed 1 year ago

jrochkind commented 1 year ago

No rush, but eventually we'll want to deal with this, combustion is triggering deprecation warning in current edge Rails 7.1

DEPRECATION WARNING: Calling ActiveRecord::Base.clear_active_connections! is deprecated. Please call the method directly on the connection handler; for example: ActiveRecord::Base.connection_handler.clear_active_connections!. (called from reset at combustion-8916f6bec7f1/lib/combustion/databases/postgresql.rb:5)

pat commented 1 year ago

Just resolved this with c1bc7dadc498c970cc24f4630dda6fe4add3e6aa - and then removed MRI 2.4 and 2.5 from the test matrix, and added in 3.2 :)

jrochkind commented 1 year ago

awesome, thanks!