search

pat / combustion

Simple, elegant testing for Rails Engines
MIT License
707 stars 51 forks source link

deprecation warning on Rails 7.1 on config.active_support.cache_format_version = 6.1 #133

Closed jrochkind closed 6 months ago

jrochkind commented 8 months ago

Rails: 7.1.1 Combustion: 1.3.7

DEPRECATION WARNING: Support for config.active_support.cache_format_version = 6.1 has been deprecated and will be removed in Rails 7.2.

Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format for more information on how to upgrade.

on Combustion.initialize! :all

ankane commented 8 months ago

Hi @jrochkind, this was fixed in #131 (but hasn't been released).

jrochkind commented 6 months ago

@ankane @pat Thanks! Are y'all interested in a combustion release anytime soon?

It looks like the last release was 1.3.7 in June 2022 (~18 months ago)

I'd love to get a release that includes all these fixes for 7.1 deprecation warnings, such #131 and also c1bc7dad

I like to keep clean output on my rspec console, these deprecation warnings are distracting and increase the risk I'll miss other deprecation warnings that are actionable!

Thank you!

pat commented 6 months ago

Sorry for the delay, finally got a new release out! (1.4.0)

Here's hoping I'm a bit better at keeping up with OSS things this year 😅

jrochkind commented 6 months ago

thanks @pat!