I must enter a title to submit a pull request

pat / combustion

Simple, elegant testing for Rails Engines

MIT License

708 stars 51 forks source link

I must enter a title to submit a pull request #17

Closed nilclass closed 11 years ago

nilclass commented 12 years ago

thanks for the great work. though this gave me the creeps.

pat commented 12 years ago

I lifted that code straight from Rails - annoyingly, they don't have it separated out into a module or class, it's in their rake tasks. Which makes reusing it a little tricky.

What's the advantage of supporting RAILS_ENV?

pat commented 11 years ago

Hi Niklas

I know it's been a while, but just wanted to let you know: I'm closing this pull request, as I'm not sure what the value is in supporting RAILS_ENV/environments other than test, given the purpose of this gem is to run a Rails app as part of a test suite.

If you can provide some reasons as to why, I'm happy to reconsider.

Cheers

Pat