pat / combustion

Simple, elegant testing for Rails Engines
MIT License
708 stars 51 forks source link

Database.setup do before Application.initialize! #53

Closed patorash closed 10 years ago

patorash commented 10 years ago

Combustion::Database.setup will do after Combustion::Application.initialize!. But Combustion::Application.initialize! is errors on Rails3.2.x if database not exists.

pat commented 10 years ago

Generally looks good - the .gitignore change isn't required though, mind removing that?

patorash commented 10 years ago

Sorry. I written by IntelliJ IDEA. IDEA generate .idea directory.

pat commented 10 years ago

Thanks for the patch :)

Might be worth looking into setting up a global gitignore so you don't need that one line in every .gitignore for every project :)

patorash commented 10 years ago

Sorry. I pushed #54 .