search

pat / combustion

Simple, elegant testing for Rails Engines
MIT License
708 stars 51 forks source link

Allow to setup app with multiple db configrations #77

Closed artofhuman closed 7 years ago

artofhuman commented 7 years ago

Allow to setup app with multiple DB configurations … Combustion recreates all databases in the database.yml config. It PR also add ability to run test for different providers in docker:

For run tests in docker just run make

U can see build log here: https://travis-ci.org/artofhuman/combustion/builds/164398228

artofhuman commented 7 years ago

@pat /cc

artofhuman commented 7 years ago

@pat Can u take a look?

pat commented 7 years ago

Hi @artofhuman - I haven't forgotten about this, it's just that the tail end of the year has been particularly busy. Hoping to have a proper look next week when I'm on a break.

pat commented 7 years ago

Hi Semyon - just reviewing this now (finally!). I'm happy for Combustion to handle multiple databases, so merging that part in sounds good. However, what's the purpose of adding Docker in? Is there a need for this?

artofhuman commented 7 years ago

@pat Thanks for the review 🎄 . About docker, I add docker for simplifying testing. For example, if a developer has not all databases installed on his machine. Also, docker allows run tests in Travis in few lines config. If you do not want docker in this repo we can remove that anyway.

pat commented 7 years ago

It's certainly a nice idea of having Docker, I just feel it's not necessary, and I'd prefer to keep things simpler. So, if you could alter the pull request to be just the database changes, that'd be great :)

artofhuman commented 7 years ago

I remove docker and change travis config, last build https://travis-ci.org/artofhuman/combustion/builds/188466722

pat commented 7 years ago

Great, thank you! Just merged it in :)

artofhuman commented 7 years ago

thanks 👍