decide per index to reconcile class name field

pat / thinking-sphinx

Sphinx/Manticore plugin for ActiveRecord/Rails

http://freelancing-gods.com/thinking-sphinx

MIT License

1.63k stars 469 forks source link

decide per index to reconcile class name field #1222

Closed akostadinov closed 2 years ago

akostadinov commented 2 years ago

Presently we only remove the class name field if there's no index with inheritance at all among the ones defined. This commit reconciles all possible indices, skipping only the ones where this field is needed.

pat commented 2 years ago

The logic on this seems fine to me, but CI's not happy - even though the tests pass on my own machine. I'm going to try to figure out why (and maybe migrate CI over to GitHub Actions now that they support retrying of failed jobs, see if that helps)

pat commented 2 years ago

I had your change in a local branch, rebased it, found the source of the bug (my fault from a long time ago), and merged both your rebased commit 5ccb9005a4d51ac1d49419b76415f7dd3b6aa622 and my fix e12b784a7cf0cd39834495644fe839ae765532f0 into develop :)