search

pat / thinking-sphinx

Sphinx/Manticore plugin for ActiveRecord/Rails
http://freelancing-gods.com/thinking-sphinx
MIT License
1.63k stars 469 forks source link

Updating GitHub CI build matrices #1238

Closed jdelStrother closed 1 year ago

jdelStrother commented 1 year ago

This updates Github CI to include sphinx 2.2.11, and updates the list of supported rubies to test manticore against.

Sphinx 2 does work ok, AFAICT, though a few times it hit the 12 minute timeout. Re-running the action fixed it.

I did experiment with removing the extra sleep calls we use with ENV['CI'] - seemed like the manticore tests were fine with it, but it did cause a few extra sphinx failures.

After this update, we have 60 manticore test runs, and 45 sphinx, which seems quite a lot. Is it worth thinking about dropping Rails 5.x support? Or at least 5.0 & 5.1 ?

Want me to remove the Travis & CircleCI config, or are they still useful after this?

pat commented 1 year ago

Ah, nice work with Sphinx 2.2.11! Thank you :)

Yes, I think we're good to remove the Circle and Travis configurations. I'll have a ponder about which versions of Rails to support.