search

pat / thinking-sphinx

Sphinx/Manticore plugin for ActiveRecord/Rails
http://freelancing-gods.com/thinking-sphinx
MIT License
1.63k stars 470 forks source link

Rails 7.1 LogSubscriber color() deprecation #1261

Closed rpheath closed 4 months ago

rpheath commented 5 months ago

In Rails 7.1 the color(...) method no longer accepts true as the third argument for "bold". Instead, you have to pass bold: true.

The LogSubscriber in thinking-sphinx has log output using the deprecated format, which results in a billion deprecation messages in application logs.

Is it possible to make an update to address this? Thanks!

rpheath commented 5 months ago

Oh! I see that PR #1252 addresses this. Any chance it will be merged/released?

pat commented 4 months ago

Closing this as #1252 is merged (and hopefully will be released shortly!)