search

pat / ts-delayed-delta

Manage delta indexes via Delayed Job for Thinking Sphinx
http://ts.freelancing-gods.com
MIT License
73 stars 33 forks source link

Use self.table_name instead of set_table_name to fix Rails 3.2 deprecation message. #18

Closed jviney closed 12 years ago

ares commented 12 years ago

+1 to merge this

pat commented 12 years ago

I've not yet merged this because it needs to be compatible across Rails versions - which I've not yet made the time to figure out. If someone else wants to do that, that'd be great :)

ares commented 12 years ago

table_name= is alias for set_table_names since rails 1.2. But if you want to be perfectly sure you can checkout my fork https://github.com/igloonet/ts-delayed-delta

but I think jvineys solution is sufficient...

jviney commented 12 years ago

Yes as far as I know, this method has been around for a long time.

ares commented 12 years ago

I did research on ActiveRecord source, it was not documented but alias is there since rails 1.2 (I didn't find older sources) so I'm pretty sure this is compatible.

pat commented 12 years ago

Thanks for the checks, just merged this in :)