search

pat310 / google-trends-api

An API layer on top of google trends
https://www.npmjs.com/package/google-trends-api
MIT License
889 stars 176 forks source link

fixes 429 errors from trends.google.com #106

Closed splatcollision closed 6 years ago

splatcollision commented 6 years ago

by checking for that status code, and storing and using the set-cookie value for an immediate re-request, and subsequent requests.

Should fix https://github.com/pat310/google-trends-api/issues/105 as per some discussion there. Let me know if you think any test script updates would apply for this fix.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.5%) to 97.638% when pulling 40f4e443184350b63d5f6fb0553d820278d45ac5 on splatcollision:master into a05ada2bd2d889df8524d600b6b46415529e80d1 on pat310:master.

Timvdv commented 6 years ago

Could someone please merge this? I'm also running into limit problems.

pat310 commented 6 years ago

Yes I'll get it merged today. Thanks @splatcollision !

On May 29, 2018, at 13:01, Tim van de Vathorst notifications@github.com wrote:

Could someone please merge this? I'm also running into limit problems.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

splatcollision commented 6 years ago

Super - thanks! @pat310

Timvdv commented 6 years ago

Awesome! Thanks for the quick response @pat310 and @splatcollision for the fix

pat310 commented 6 years ago

@splatcollision @Timvdv new version 4.6.2 is published and up on npm!

jasonadkison commented 6 years ago

Thank you, fix is working great @splatcollision.