pat310 / google-trends-api

An API layer on top of google trends
https://www.npmjs.com/package/google-trends-api
MIT License
894 stars 178 forks source link

Usage without leveraging node.Agent #149

Open Fohlen opened 3 years ago

Fohlen commented 3 years ago

Currently this library is heavily restricted as any proxy implementation must follow the http.Agent implementation. However, for many other environments it is desirable use the library only for preprocessing. A function should then yield:

In this way it can then be used with other software such as fetch or request (potentially in any language). Would it be feasible and desirable to do such a refactoring in utilities.js ? The end result would be a get_options function (or similar) that is both internally used and exported.

If this is desirable let me know:

All the best, Lennard

pat310 commented 3 years ago

Hi Lennard, a PR would definitely be welcome! I’ve really fallen off on this project

On Dec 20, 2020, at 10:05, Lennard Berger notifications@github.com wrote:

 Currently this library is heavily restricted as any proxy implementation must follow the http.Agent implementation. However, for many other environments it is desirable use the library only for preprocessing. A function should then yield:

the URL which would be forwarded to http.Agent including the query necessary cookies or HTTP parameters In this way it can then be used with other software such as fetch or request (potentially in any language). Would it be feasible and desirable to do such a refactoring in utilities.js ? The end result would be a get_options function (or similar) that is both internally used and exported.

If this is desirable let me know:

would you like to implement something like this or would you accept a PR for such a feature? All the best, Lennard

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.