search

pat310 / google-trends-api

An API layer on top of google trends
https://www.npmjs.com/package/google-trends-api
MIT License
877 stars 175 forks source link

Fixed an issue with using a proxy agent that happened when making a m… #96

Closed aaronmefford closed 6 years ago

aaronmefford commented 6 years ago

There was an issue with the proxy agent change that broke multiple keyword queries when an agent was used. This change fixes that problem.

Because I needed to remove the agent from the obj before the call to formatKeywords, I am cloning the obj so as not to modify the callers data structure and create a side-effect. It did not seem appropriate to add the logic to formatKeywords to filter out the agent.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.7%) to 96.46% when pulling 49429f1027697243989fce29f59fff770e1ffabc on aaronmefford:master into 01dd2761fc2817688a02326d834d3d316e83ce46 on pat310:master.

pat310 commented 6 years ago

Thanks @aaronmefford! I actually just published version 4.6.1 which contains a proxy fix. Can you let me know if that works for you?

pat310 commented 6 years ago

Closing because I believe this was taken care of in 4.6.1, will reopen if not!