search

pat310 / quick-pivot

Quickly format data to create a pivot table
https://www.npmjs.com/package/quick-pivot
MIT License
63 stars 21 forks source link

fix for #37 #38

Closed turnerniles closed 7 years ago

turnerniles commented 7 years ago

@pat310 I think preferably in the collapse function in progressiveDiscovery.js, collapsed should just not be returned. If the depth of the row being collapsed is the maximum depth (rows.length-1) collapsed should just return. We would have to pass the collapse function row/rows.length in progressiveDiscovery.js, but I think it's fine.

Let me know your thoughts on the issue and the solution options.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.09%) to 96.277% when pulling 6767b734df6435069621604c2bb4dbcd1ab3f799 on stop-collapsing-at-lowest-level into 1784ab0386879d8de6b5b9bf1738a354ff3da240 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+2.09%) to 96.277% when pulling 6c906603ce99ad0f55e414ccec616776dcb38dc1 on stop-collapsing-at-lowest-level into 1784ab0386879d8de6b5b9bf1738a354ff3da240 on master.