search

pat310 / quick-pivot

Quickly format data to create a pivot table
https://www.npmjs.com/package/quick-pivot
MIT License
63 stars 21 forks source link

getUniqueValues returns the original unique values even after filtering #51

Closed pat310 closed 7 years ago

pat310 commented 7 years ago

@turnerniles closes #50

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 97.696% when pulling 464338b4cc91ae78fe56a3f101519eca7d0b8efa on 50returnOriginalUniqueValues into 08fe5f07debcfe97a1ccab9a0a6911c16eb68450 on master.

turnerniles commented 7 years ago

It's weird lines 48 and 49 aren't hit by the test you wrote. I think they are...

pat310 commented 7 years ago

Hmm, just wrote a test to fix that...

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.006%) to 98.618% when pulling 3ec65f30ee142716a9929a2f677e6d4151fee526 on 50returnOriginalUniqueValues into 08fe5f07debcfe97a1ccab9a0a6911c16eb68450 on master.