search

pat310 / quick-pivot

Quickly format data to create a pivot table
https://www.npmjs.com/package/quick-pivot
MIT License
64 stars 21 forks source link

Progressive filtering modification #54

Closed turnerniles closed 7 years ago

turnerniles commented 7 years ago

Upon filtering sets originalArgs.data equal to the filtered data which is then used in successive filter method calls.

This naming is confusing since originalArgs.data will not always contain the originalArgs and will contain the "filteredArgs" but I don't think we need to add an additional filteredArgs property to the Pivot class. this.originalData is also set equal to the result of the filtered data in the update method so perhaps we should consider renaming originalArgs and originalData.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling 4908341ec9df218079270b66b6eb76d59e61f043 on progressive-filtering-modification into ee282333454d15ee5755292833df05464e87b2e0 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling 0a4bbf44facab4ac5f6b9884605f93789d897c03 on progressive-filtering-modification into ee282333454d15ee5755292833df05464e87b2e0 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling 482103d9829e8f4d9b65493e395f3312ea21a312 on progressive-filtering-modification into ee282333454d15ee5755292833df05464e87b2e0 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling 4d7e399ad97ae1b4cb824aae10a3e599264efd35 on progressive-filtering-modification into ee282333454d15ee5755292833df05464e87b2e0 on master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.006%) to 98.624% when pulling f0894384e973cb156c2bd392ba223c06338c9b99 on progressive-filtering-modification into ee282333454d15ee5755292833df05464e87b2e0 on master.