search

patak-dev / vite-plugin-terminal

Log in the node terminal from the browser
MIT License
264 stars 17 forks source link

Limited output for `event` object #32

Open danielkellyio opened 3 weeks ago

danielkellyio commented 3 weeks ago

See the reproduction here: https://stackblitz.com/edit/vitejs-vite-13prbv?file=vite.config.js,src%2FApp.vue,src%2Fmain.js&terminal=dev

All that's logged to the terminal is 

{
  "isTrusted": true
}

I would expect the full event to be logged. Thanks!

patak-dev commented 3 weeks ago

Hey @danielkellyio, interesting bug. I wasn't expecting to log the whole Event object. I'm thinking it may be a good idea to destructure what props you want instead as it will be noisty anyways. Semi-related to this bug, I'm thinking on deprecating this plugin in favour of unplugin-turbo-console https://utc.yuy1n.io, that now supports the feature set of vite-plugin-terminal and much more. I would be interested in knowing how it works for you to have another data point for doing the call.

danielkellyio commented 3 weeks ago

@patak-dev we use this plugin in the Vue certificate so that users don't have to dig through the real browser console for debugging coding challenges (there are several logs there from our proctoring service that make it quite noisy).

The goal for us was to replicate what would be sent to the console normally to also be sent to the terminal in the stackblitz embed (without the user doing anything out of the normal. ie just calling console.log).

Is that possible with unplugin-turbo-console?

I'm having trouble understanding exactly how that would work. My attempted replication but not working: https://stackblitz.com/edit/vitejs-vite-ebn9mj?file=vite.config.js,src%2Fmain.js,src%2FApp.vue&terminal=dev

(Maybe this isn't the right place to continue this convo. Let me know if not :) Thanks!)

danielkellyio commented 3 weeks ago

My primary concern for the context of our coding challenge, is that people can see the key property of a keyboard event. https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key