search

patbat / khuri

Khuri-Treiman equations / dispersion relations
GNU General Public License v3.0
1 stars 0 forks source link

consistent units #13

Closed patbat closed 5 years ago

patbat commented 5 years ago

When possible, the code should/does not rely on a specific choice of units. An exception arises if there are fixed input parameters that carry a dimension, e.g. in the parametrizations by the Madrid group. In this case one needs to make a choice of units (e.g. MeV, GeV, ...). This choice should be global, otherwise great confusion arises. Hence

  1. remove constants that are not needed (e.g. pion masses etc. in cpp/include/constants.h)
  2. make a global consistent choice of units (most likely either MeV or GeV)
  3. adapt this choice everywhere and document the choice in a very visible place, for it affects users
patbat commented 5 years ago

GeV is the natural choice. The old Madrid p-wave phase does not yet conform to it (instead MeV are used). Hence the test of the Omnes function also uses MeV. Change this.