search

patbat / khuri

Khuri-Treiman equations / dispersion relations
GNU General Public License v3.0
1 stars 0 forks source link

test omnes function (only!) via python interface #6

Closed patbat closed 5 years ago

patbat commented 5 years ago

Instead of testing the omnes function directly via its c++ implementation, test is via its python interface.

This is beneficial for the following reason: the pure cpp tests shall be reserved for facilities that do not have a python interface (for the latter would be useless/is not needed), everything else shall be tested via python. In this way, the tests are clearly seperated and one avoids unnecessary doubling of similar tests just for the purpose of testing the pybind11 bindings.

patbat commented 5 years ago

The test suite for the omnes function should be extended significantly (i.e. plug in a madrid phase into the omnes function etc.)

patbat commented 5 years ago

One should also test if the Schwarz reflection principle is fulfilled.