search

patcg-individual-drafts / private-aggregation-api

Explainer for proposed web platform API
https://patcg-individual-drafts.github.io/private-aggregation-api/
39 stars 16 forks source link

Add requiredSellerCapabilities check when processing auctionReportBuyers #134

Open morlovich opened 1 month ago

morlovich commented 1 month ago

...to avoid generating auctionReportBuyers style contributions for buyers/ interest groups that got filtered out due to failing requiredSellerCapabilities check.

Preview | Diff

morlovich commented 1 month ago

The Chrome implementation makes the same sort of mistake(?) for "interestGroupCount" --- we can send it for buyers who had no interest groups eligible for the auction due to requiredSellerCapabilities(!). I think that's a bug. The spec also seems to send 0 for bidCount when the buyer has no IG's eligible due to requiredSellerCapabilities, which feels a bit better (but is not what Chrome does for the metric), but is probably still not the right thing to do.

The things Chrome does with "totalGenerateBidLatency" (and less so with "totalSignalsFetchLatency") are quite divergent, but to extent they are more of a big issue rather than a minor bug, so will require totally different handling.