search

patcg-individual-drafts / private-aggregation-api

Explainer for proposed web platform API
https://patcg-individual-drafts.github.io/private-aggregation-api/
43 stars 19 forks source link

Spec: Fix algorithm declarations #147

Closed dmcardle closed 3 weeks ago

dmcardle commented 1 month ago

The Bikeshed Documentation (dated 8 March 2024) says, "Algorithms can be explicitly indicated in your markup by putting the algorithm attribute on a container element or a heading" 1.

Through trial and error, I discovered that algorithm-specific markup is not generated when you write <dfn algorithm>. Instead, the <dfn> tag must be wrapped in something like <div algorithm>.

This change has at least two positive results:

  1. Local variables are no longer declared in the global scope!
  2. We can now click on local variables and they are highlighted in pretty colors.

Preview | Diff

dmcardle commented 1 month ago

@alexmturner PTAL!

I'm not sure how exactly the Shared Storage monkey patches should be marked up, but there's an Issue tracking that in spec.bs.

dmcardle commented 1 month ago

@alexmturner PTAL!

dmcardle commented 3 weeks ago

Hey Alex, PTAL :)