search

patcg-individual-drafts / private-aggregation-api

Explainer for proposed web platform API
https://patcg-individual-drafts.github.io/private-aggregation-api/
41 stars 17 forks source link

Change API layering in spec #51

Closed alexmturner closed 1 year ago

alexmturner commented 1 year ago

Creates new exported algorithms and one algorithm to be overriden. This cl doesn't actually move any content to other specs, but is a step to making that simpler. This change also addresses batching, by defining the batching scopes more completely.

Preview | Diff

alexmturner commented 1 year ago

@yoavweiss could you take a quick look? I wasn't sure if this was the best direction towards fixing the layering, but I'm trying to allow each implementing API to define its own 'batching scope'. Specifically, I wasn't really sure whether functions being 'overridden' was a well-supported spec concept. Thanks!

alexmturner commented 1 year ago

I've reworked this to separate out the parts that will (eventually) be moved to other specs into separate sections at the end as well as moved from 'overrides' to having a field that gets set by implementing specs

cc @linnan-github

alexmturner commented 1 year ago

@linnan-github, could you PTAL? Thanks!

alexmturner commented 1 year ago

@yoavweiss Thanks for the feedback! Had a go reworking to better integrate with the specs. Ran into a few issues with the other specs, so opened issues and noted those in this spec too where relevant. Some of the integrations I've put here are a little more handwavy than I'd like, but that should be fixable once those issues are resolved.

alexmturner commented 1 year ago

Thanks for all the improvements!