search

patcg-individual-drafts / topics

The Topics API
https://patcg-individual-drafts.github.io/topics/
Other
605 stars 199 forks source link

Explainer and spec update for padding #186

Closed xyaoinum closed 1 year ago

xyaoinum commented 1 year ago
  1. Update the header format, and include the padding algorithm, per discussion in https://github.com/patcg-individual-drafts/topics/issues/183.
  2. Reorder the comparator conditions of BrowsingTopic (i.e. "version" first, and then "topic id"). This aligns with the current implementation.
xyaoinum commented 1 year ago

@domenic PTAL. Thanks! (Thanks for filing the issues giving suggestions to the spec. I will address them later, but this patch is a behavior change and we'd like to add it to the spec first)

@jkarlin PTAL. Thanks!

xyaoinum commented 1 year ago

@domenic I switched to always expose the version per your suggestion (although still would like to see Josh's position), and addressed your other comments. PTAL again. Thanks!

xyaoinum commented 1 year ago

Thanks @domenic! Landing this now. I will create followup PR for the clarity improvement and other feedback if any.