search

patdunlavey / orienteering-usa

orienteeringusa.org
GNU General Public License v2.0
2 stars 1 forks source link

Error message when banner not selected #11

Closed ousaweb closed 13 years ago

ousaweb commented 13 years ago

The error message that appears when a page is created but a banner is not selected is:

* An illegal choice has been detected. Please contact the site administrator.
* Banner: this post can't be referenced.

While not critical, the message is scary. I don't suppose it can be changed to "please select a banner"?

patdunlavey commented 13 years ago

It may be possible to change the error message, but I'll have to spend some time exploring form validation and error message api's. But another option may be to set one banner image as the default for Page nodes. If we did that, which image would you select?

ousaweb commented 13 years ago

Though I like the ones of runners approaching control flags, I think the red O banner (says Orienteering) is most inclusive (doesn't ignore ski O, mtbO and trail O), and also bright enough to get an editor's attention if they want to change it.

patdunlavey commented 13 years ago

Done. New pages will have this selected by default. (We haven't fixed the error message, we're just making it less likely to be encountered.) Incidentally, when you enter a comment, you have a choice of two buttons: "comment", and "comment and close". I saw that you closed this one, and I don't think you meant tha(?). But I think we can now consider this one closed!