search

pateketrueke / yrv

Your routing vibes! (for Svelte)
https://svelte.dev/repl/0f07c6134b16432591a9a3a0095a80de
161 stars 9 forks source link

fix: Adds changes to move to ubuntu runner instead of self-hosted #71

Closed jhechtf closed 3 years ago

jhechtf commented 3 years ago

In my initial PR I didn't notice that I left the "self-hosted" in the runs-on value.

This should remedy that, and beside from not being able push files up due to conflicting tags seemed to function well on my fork.

jhechtf commented 3 years ago

RE: your concerns about updates being triggered for minor things:

That's the whole point of automating them is that they will get triggered for minor things, sure, but that will also mean the deadtime between merger + deployment to NPM is lowered as well. It's the driving ideology behind CI/CD. the one thing i would want to change, that I am unsure how particularly in Github Actions (as I'm less accustomed to them) is to ensure that the testing stage passes before the release.

We could, in theory, switch the release on the main branch to be a manual action, allowing us to deploy only after a manual action is taken. I'm personally against this whenever possible as I prefer things to be automated.

We can switch the branch to a different branch (e.g. "release" as you suggested), but then I'd like to have a scheduled release of at least once every two weeks in case something happens in your day-to-day life and you forgot to merge things from master to the release branch.

pateketrueke commented 3 years ago

~Agreed, I'll update the repo secrets and fire a manual build if no other commits arrive in 72hr, thank you!~

Nevermind, I just noticed tags were created but not published so I published those manually; next time will be automatic, again so much thanks for your time!