discospiff
commented
2 years ago From this review: Updating the unit test name to be more descriptive is a good idea.
This branch introduces new, and possibly incomplete, functionality, instead of reducing technical debt of existing functionality. New functionality should be kept in a separate branch until it is complete and meets the team's Definition of Done. Thus, if the team would like these features, they can keep the branch open and continue to work on it, and then merge once it meets the Definition of Done. Otherwise, if they do not want these changes, they can abandon/delete this branch and not merge it.
Was the program able to compile? The program was able to compile without retrofit
Was the program available in UC Github on time? The program was available on time
Rationale The program was missing a data class for storing computer parts so I went ahead and created one with different computer parts (https://github.com/pranavm7/UniConnect/commit/441ac324c5a14ebde61f994498dd7e2e3bc98a79)
(https://github.com/pranavm7/UniConnect/commit/08e063b879fe3fb01985480daf115cc082200e36)
I also created a unit test for the parts. (https://github.com/pranavm7/UniConnect/commit/0d4375a66963ce6e5c9857a2b4c70d4016bddb61)