search

patelmayankce / react-apple-login

A Apple Log-in Component for React
MIT License
65 stars 21 forks source link

UsePopup option #8

Closed serra-caio closed 3 years ago

serra-caio commented 4 years ago

Is there a way to enable the usePopup option?

Thanks

patelmayankce commented 4 years ago

Sorry right now there is no support of Popup.

ohpyupi commented 4 years ago

@patelmayankce With the way the code is implemented, it looks it could entail some code refactoring to support the popup option. https://github.com/patelmayankce/react-apple-login/blob/master/src/index.tsx#L50

By using the Javascript SDK provided by Apple, we can support the popup option. https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_js/configuring_your_webpage_for_sign_in_with_apple

patelmayankce commented 4 years ago

@ohpyupi ,Sorry for very late reply, You are right Apple is now supporting popup option.

marcin-wicha commented 4 years ago

@patelmayankce If you're too busy you can assign it to me :) I'll add the popup option over the weekend.

patelmayankce commented 4 years ago

@marcin-wicha , If you can help anyhow, that would be appreciated.

I already did some code but after successful authentication popup wasn't closed automatically. I will push that code into a new branch and share it with you.

muth0mi commented 4 years ago

I kept getting the same issue but found a solution in this thread Sign in with apple js use popUp. For popup, the redirect url should be the root domain.

patelmayankce commented 4 years ago

Thanks @muth0mi, i will check quickly and release the new version with support of popup.

patelmayankce commented 3 years ago

@serra-caio @marcin-wicha @muth0mi usePopup option added https://www.npmjs.com/package/react-apple-login/v/1.1.1

Guys thanks for the help.