paternogbc / sensiPhy

R package to perform sensitivity analysis for comparative methods
http://onlinelibrary.wiley.com/doi/10.1111/2041-210X.12990/full
GNU General Public License v2.0
12 stars 4 forks source link

Some more changes (sorry!) #178

Closed gijsbertwerner closed 6 years ago

gijsbertwerner commented 6 years ago

While going over the package one last time, I am running into a few minor things and have made changes. I know this means we'll have to rerun the manuals etc., @paternogbc . Sorry! Just thought I'd maintain a list of changes I have made for our records.

Ok, done now I think (with the exception of the bit below)!

gijsbertwerner commented 6 years ago

Stuff to do still:

paternogbc commented 6 years ago

Hey @gijsbertwerner that is great! Thanks. Yep, the code with n.tree = 1 is to pass Cran tests. \dontshow are executed by CRAN but not shown to users. \dontrun are shown but not executed.

So we always want to run at least one test of the function (to be sure it is not broken), but this needs to be faster then 5 sec.

Regarding the other changes, excellent! And no worries about re-building stuff, it is great to know we cleared small typo/bugs =)

gijsbertwerner commented 6 years ago

Great, makes sense, Gustavo! I figured that that's what it would work like.

I can do the sensi_plot methods update tomorrow, but am afraid superbusy today.

paternogbc commented 6 years ago

@gijsbertwerner, I can do it no worries. I will try to submit the package tonight (Aussie time).

I have pushed this 91a5542c9faed1431e489ec906a63195faa779e9. Still missing the help for the sensi_plot.sensiSamp.TraitEvol.

Cheers!

gijsbertwerner commented 6 years ago

Cool, I have added the help for sensi_plot.sensiSamp.TraitEvol now in https://github.com/paternogbc/sensiPhy/commit/76e5f0ee031d5d83a9a03f7249223b05e5f5637e and in https://github.com/paternogbc/sensiPhy/commit/56a73775a019cb1bc14b15a19b1c9679064a943b

paternogbc commented 6 years ago

Perfect, all done then! Updates the documentation in b025bde69c918ba8671735785ac4dbfd2cfd5484