paternogbc / sensiPhy

R package to perform sensitivity analysis for comparative methods
http://onlinelibrary.wiley.com/doi/10.1111/2041-210X.12990/full
GNU General Public License v2.0
12 stars 4 forks source link

CRAN request: using if() with conditions of length greater than one from a warning into an error. #184

Closed paternogbc closed 6 years ago

paternogbc commented 6 years ago

function

Check all code in the package.

Problem

These fail when checking with env var _R_CHECK_LENGTH_1CONDITION set to true, which turns using if() with conditions of length greater than one from a warning into an error.

We really would like to have (the current development version of) R move from giving a warning to giving an error by default in the near future, but would prefer not breaking too many CRAN (and BioC) packages.

We understand that you have already been contacted at least twice by Tomas Kalibera to fix your packages to no longer use if() with conditions of length greater than one: we really need new versions of your packages fixing this as soon as possible.

Please correct before 2018-05-15 to safely retain your package on CRAN.

paternogbc commented 6 years ago

Fixed on https://github.com/paternogbc/sensiPhy/commit/39531aa343f39cc421bbdb3df51125ec916c25f2