search

patflick / miopen-benchmark

benchmarking miopen
BSD 3-Clause "New" or "Revised" License
17 stars 15 forks source link

Need modification in "Makefile" and "miopen.hpp" #6

Closed pramenku closed 6 years ago

pramenku commented 6 years ago

As per latest release 1.6.4 of rocm driver , library name of rocblas and hipblas needs to be changed from ""-lhipblas-hcc , -lrocblas-hcc" to ""-lhipblas -lrocblas" Hence, Makefile needs modification as below LD_FLAGS=-L$(ROCM_PATH)/lib -L$(ROCM_PATH)/opencl/lib/x86_64 -lMIOpen -lOpenCL -lmiopengemm -lhipblas -lrocblas

Besides this, 1 minor modification requires in miopen.hpp as below

include <hipblas/hipblas.h> to #include

Only after above 2 modification, we can able to build the miopen-benchmark tests on rocm release 1.6.4

patflick commented 6 years ago

can you send this as a pull request?

pramenku commented 6 years ago

I have created pull request for above changes. Below request has 2 commits.

https://github.com/patflick/miopen-benchmark/pull/7

pramenku commented 6 years ago

Can you please merge the changes asap.

patflick commented 6 years ago

Done.

pramenku commented 6 years ago

Thanks.