path-network / logstash-codec-sflow

Logstash codec plugin to decrypt sflow
Other
35 stars 17 forks source link

Logstash >7.9.9 support #26

Open lorranmira opened 3 years ago

lorranmira commented 3 years ago

Is there a reason that logstash-core 7.9.9 is the highest version supported? Is it possible to increase this to say <8.0.0?

greig-hamilton commented 3 years ago

I believe the reason for asking the above question is when logstash 7.10.2 is installed and then logstash-codec-sflow plugin version 2.1.3 is installed there is a conflict. logstash 7.10.2 believes that logstash-core is at version 7.10.2. However the logstash-codec-sflow plugin requires logstash-core to be <= 7.9.9. So installing the plugin fails. If the plugin version isn't specified then logstash-codec-sflow version 2.0.0 is installed because there is no dependency on logstash-core but this isn't what most users want.

Can the dependency be updated to a later version or is there a specific reason it must stay at 7.9.9?

The following install command was run: bin/logstash-plugin install --version 2.1.3 logstash-codec-sflow The relevant bits of the output from this command are: Validating logstash-codec-sflow-2.1.3 Installing logstash-codec-sflow Plugin version conflict, aborting ERROR: Installation Aborted, message: Bundler could not find compatible versions for gem "logstash-core": In snapshot (Gemfile.lock): logstash-core (= 7.10.2)

hundredacres commented 3 years ago

Any progress on this? I've been collecting sflow data succcessfully until I upgraded to Logstash 7.11.0 and now I'm getting spammed with 'Unknown record entreprise 0, format xxxx' errors

laxxie commented 3 years ago

Also not able to install the latest codec

/usr/share/logstash/bin/logstash-plugin install /usr/src/logstash-codec-sflow-2.1.3.gem Using bundled JDK: /usr/share/logstash/jdk OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be >removed in a future release. Validating /usr/src/logstash-codec-sflow-2.1.3.gem Installing logstash-codec-sflow Plugin version conflict, aborting ERROR: Installation Aborted, message: Bundler could not find compatible versions for gem "logstash-core": In snapshot (Gemfile.lock): logstash-core (= 7.12.0)

In Gemfile: logstash-core java

logstash-codec-sflow (= 2.1.3) java was resolved to 2.1.3, which depends on logstash-core (>= 5.4.0, <= 7.9.9) java

logstash-core-plugin-api java was resolved to 2.1.16, which depends on logstash-core (= 7.12.0) java

logstash-input-syslog java was resolved to 3.4.5, which depends on logstash-filter-grok java was resolved to 4.4.0, which depends on logstash-core (>= 5.6.0) java

logstash-integration-jdbc java was resolved to 5.0.6, which depends on logstash-core (>= 6.5.0) java

logstash-output-elasticsearch (>= 10.4.2) java was resolved to 10.8.2, which depends on logstash-mixin-ecs_compatibility_support (~> 1.0) java was resolved to 1.1.0, which depends on logstash-core (>= 6.0.0) java

logstash-input-elasticsearch java was resolved to 4.9.1, which depends on logstash-mixin-validator_support (~> 1.0) java was resolved to 1.0.1, which depends on logstash-core (>= 6.8) java

Running bundle update will rebuild your snapshot from scratch, using only the gems in your Gemfile, which may resolve the conflict.

It would be great to get it running with the current Elastic version. The "normal" version is 2.0.0 so there is no IPv6 support =/

laxxie commented 3 years ago

I tried to help myself. I changed the version from 7.9.9 to 7.19.0 in logstash-codec-sflow.gemspec s.add_runtime_dependency 'logstash-core', '>= 5.4.0', '<= 7.9.9'

Did a gem build logstash-codec-sflow.gemspec and install the .gem file manually. It seems that everything is workking fine so far