search

path / FastImageCache

iOS library for quickly displaying images while scrolling
MIT License
8.1k stars 938 forks source link

Fixes some issues around Xcode 9 yelling about using UIKit on background threads #152

Closed rhaining closed 1 year ago

rhaining commented 7 years ago

In Xcode 9, the new main thread checker kept warning me about FastImageCache using UIApplication's isProtectedDataAvailable on a background thread. This should be innocuous, but I think Xcode 9 is just broadly looking at UIKit on background threads.

More consequently, this was preventing me from running unit tests locally on my own project.

The basic change here is to use NSNotificationCenter to watch for notifications when protected data becomes available or unavailable, and maintain that state as a static variable, which the instances can then utilize.

rhaining commented 7 years ago

This also resolves this issue: https://github.com/path/FastImageCache/issues/150

RodBrown1988 commented 7 years ago

@rhaining After chatting with @mallorypaine on Twitter, he has left Path, and this repo no longer has anyone with write access actively working on it.

I'm looking at upgrading my personal version of it, and perhaps starting a canonical side fork now that Path seem to have abandoned this repo.

rhaining commented 7 years ago

@RodBrown1988 dang! thanks for the heads-up.

yoon-boom commented 7 years ago

I guess can't find podspec, no maintenance (looks like they left path) only option is either fork-> create own branch then create your own podspec or manually hardcopy files is the only option.

mallorypaine commented 7 years ago

Please open PRs against my fork here: https://github.com/mallorypaine/FastImageCache

I will continue to maintain FIC even though Path itself is no longer maintaining it.

Sega-Zero commented 7 years ago

@rhaining, will you do this? I can make a PR if you don't have free time for it

rhaining commented 7 years ago

@Sega-Zero this PR is ready to be merged

Sega-Zero commented 7 years ago

@rhaining please, read the thread, @mallorypaine cannot merge it in this repo, we need a PR into a fork

Sega-Zero commented 7 years ago

@mallorypaine is it possible to transfer this repo to you? Is there anyone in Path who can do it?

mallorypaine commented 7 years ago

No idea. I don’t think there’s a single person left from when I was there.

k-krzyszczak commented 6 years ago

@rhaining ETA of new version with this merge?

Sega-Zero commented 6 years ago

@JeaDay this has been merged in https://github.com/mallorypaine/FastImageCache/pull/1

@mallorypaine Is it possible to update the pod? Or maybe create a new one?

rhaining commented 6 years ago

@JeaDay i don't work for Path or know anyone there. as far as i know, this project is unmaintained now. i have a fork over here https://github.com/rhaining/FastImageCache/ with those changes.