Closed jamecoyne closed 4 years ago
Oop, good catch on the .code-workspace. I turned off strict mode to try suppress some issues I was having, but it’s not essential and should be set to true. I’ll fix and recommit shortly.
Yea, no worries. If there are still issues feel free to leave it as false. I was just curious :) good work On Mar 18, 2020, 10:33 AM -0400, Jame Coyne notifications@github.com, wrote:
Oop, good catch on the .code-workspace. I turned off strict mode to try suppress some issues I was having, but it’s not essential and should be set to true. I’ll fix and recommit shortly. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.
Thanks! Just fixed it, ready to merge if y'all see no other issues :^)
To my knowledge, we don't have any open issues pertaining to this, but I did it anyway!
The long and short of these changes:
visited
andpath
and currently render as different colors pertaining to this.Further work and things to consider
Personally I think we might consider a better way to store
path
andvisited
in MazeInfo, for one thing, currently walls are given these props while only empty spaces will ever be visited/used as a path.It might be good to eventually split
startPoint
andendPoint
into their own subcomponents as well just for readability, as well as if they end up having their own custom mesh or materialthree.js's raycasting system has an issue where it doesn't occlude objects, meaning that sometimes if the camera is angled correctly you can select like two or three spaces at once. I'm guessing that there might be an easy fix for this. The problem isn't mission-critical, but it does detract from the user experience and it's worth investigating further as a stretch goal.