patheros / PathSetXOmriCohen

Manuals and Issues for the Path Set X Omri Cohen plugins for VCV Rack
4 stars 0 forks source link

Remove short fade in at start of playback #10

Closed patheros closed 1 year ago

patheros commented 1 year ago

Thank you, I solved the pitch problem by adjusting the sample rate, but other problems still exist, the sound head problem is: every time the sound head is played, the head sound has a short volume fade in.

Originally posted by @283062766 in https://github.com/patheros/PathSetXOmriCohen/issues/8#issuecomment-1573096100

patheros commented 1 year ago

So I was able to reproduce this issue using a pure sine wave sample. Here you can see the fade in clearly happening on the scope: image

I believe what is happening is the tapper on the grain is showing through here. Each grain is tapered in and out using a hanning window. But when the sample first starts playing, there are no grains already playing, so the tapper of the first grain is clearly noticeable.

Overall though I'm not sure this is a problem? This tapper prevents harsh clicks/pops.

omricohenmusic commented 1 year ago

I believe that since the granular engine is always on, it's just a matter of changing the parameters to get a different result. For example, in this case, lowering the grain size will get rid of the fade in.

https://github.com/patheros/PathSetXOmriCohen/assets/51967995/52c030bd-d123-4b94-b51a-f6e7ec583161

283062766 commented 1 year ago

I tried it and it did, I was misled by the defaults, this doesn't seem to be the problem, thanks a lot for helping me!

patheros commented 1 year ago

Great! I'll close this ticket.