pathmann / pyTSon

pyTSon is a plugin for the TeamSpeak 3 client, it offers a python interface for the plugin sdk
https://pytson.4qt.de
GNU General Public License v3.0
79 stars 12 forks source link

MultiSelect Move incompatible with Dark Themes #107

Closed exp111 closed 6 years ago

exp111 commented 6 years ago

Channel & Client Names are black. Spacers are white though.

pathmann commented 6 years ago

Not sure if this belongs here.

  1. Multiselect move is a plugin, but the base treeview is indeed part of the core.
  2. My guess is, that it's more or less an issue of the theme (if the view is styled, but the child items are not in a consistent way, it looks like a theme issue). So any plugin using a QTreeView will have this problem.

As long as you don't provide any link to the theme, nobody can say for sure.

exp111 commented 6 years ago

Using DarkenTS. The Font color gets set like this: QTreeView::item:selected:active, QTreeView::item:selected:!active { background-color: rgb(62,79,94); color: rgb(216,216,216); } and QWidget { font-family: "Segoe UI", Arial, sans-serif; color: rgb(216,216,216); }

The ServerView Rows are probably not QWidgets or smth.

pathmann commented 6 years ago

That's how it looks in my client with DarkenTS.

multiselectmove_darkents

I see what you mean, but I'm not that experienced with CSS/Stylesheets and don't know, why the Stylesheet is not applied to it respectively only applied "half".

exp111 commented 6 years ago

The problem is that you draw with your paint function (in ServerviewDelegate) over the things. A (probably dirty) fix is removing the painter.setPen & painter.setFont calls in the paint function.

Edit: Proper Fix: Don't default to white and only change if brush/font exists. Get the font not from QApplication.font(), but rather from the serverView/tabWidget.