pathofleastresistor / polr-ytube-media-card

26 stars 3 forks source link

Playlist icons not always loading #1

Open KoljaWindeler opened 6 months ago

KoljaWindeler commented 6 months ago

Hi @pathofleastresistor I absolutely love what you are doing here. Just tested 1.5 Small ideas:

Again: greet work!

pathofleastresistor commented 6 months ago

if we only one track is in the playlist it looks odd. Can the card height be adjusted dynamically?

Yeah I agree that a single track does look weird right now. That said, I explicitly chose to make the card a fixed height to avoid issues where dynamic card height changes cause weird layout issues (especially if you're doing a masonry layout). I'll think more about better layouts though.

could you show the covers when searching ?

Perhaps I'm missing something, but I do see covers when searching. More generally speaking, if the item has a thumbnail set in the Media Browser, this card should prefer to show it over the basic music note icon.

image
KoljaWindeler commented 6 months ago

ha .. you're right .. during search there are icons .. but not in the playlist view image

where do you get the "next items" list from anyway? from the extra sensor?

understand the fixed layout argument .. fair enough

pathofleastresistor commented 6 months ago

Ahh okay - so right now I get the "next items" from "Current Playlists" in the Media Browser. I checked in the media browser and that also doesn't show album art. All this card does is send a WebService call to get the data from that page.

I think your component sets it here - https://github.com/KoljaWindeler/ytube_music_player/blob/main/custom_components/ytube_music_player/browse_media.py#L496

KoljaWindeler commented 6 months ago

Funny .. it works with playlists.
Ok so not a to-do for you but for me Excellent. https://github.com/KoljaWindeler/ytube_music_player/issues/286

KoljaWindeler commented 6 months ago

Works fine with https://github.com/KoljaWindeler/ytube_music_player/commit/930b590d007aeb9a744953131c10162238f803d9

KoljaWindeler commented 6 months ago

ok, i don't get it. I've added a call to copy the thumbnail from an album to each track and confirmed that it is working with the current_playlist in the media_browser image

works .. but on the card it is not visible .. strange right?

image