search

pathpy / pathpyG

GPU-accelerated Next-Generation Network Analytics and Graph Learning for Time Series Data on Complex Networks.
https://www.pathpy.net
GNU Affero General Public License v3.0
33 stars 3 forks source link

Missing `pre-commit-config.yaml` #185

Closed jvpichowski closed 4 months ago

jvpichowski commented 6 months ago

I use the devcontainer.

When committing it says:

No .pre-commit-config.yaml file was found
- To temporarily silence this, run `PRE_COMMIT_ALLOW_NO_CONFIG=1 git ...`
- To permanently silence this, install pre-commit with the --allow-missing-config option
- To uninstall pre-commit run `pre-commit uninstall`

In the documentation for Contributing.md it says:

The checks are documented in detail in `pre-commit-config.yaml`.

I can't find that file, too. Also running pre-commit install did not help.

Did I miss-configure something?

M-Lampert commented 4 months ago

I removed the precommit configurations in #188 since they were more annoying than helping. DevContainers and potentially also other setups where precommit install was executed during setup need to run precommit uninstall as a fix. Rebuilding the dev container would also work. Afterwards this should hopefully never lead to any problems since it should be completely removed now.