search

patil-ashutosh / go-regex-utility

A curated list of golang applications using regex
MIT License
3 stars 8 forks source link

date validation regex added. #26

Closed souvikmaji closed 4 years ago

souvikmaji commented 4 years ago

this fixes #24

souvikmaji commented 4 years ago

@patil-ashutosh can you help me identifying why the code coverage tool is failing?

patil-ashutosh commented 4 years ago

@patil-ashutosh can you help me identifying why the code coverage tool is failing?

@souvikmaji Please Refresh branch and try again. also please try to address comment

souvikmaji commented 4 years ago

@patil-ashutosh, The separation between the different segments was not clear cut because of the different edge cases, e.g., month-end dates, leap years. But I tried to split it as much as possible though I am not fully satisfied with the variable names. Please review and let me know if anything can be improved further.

souvikmaji commented 4 years ago

Hi @patil-ashutosh , any update on this?

patil-ashutosh commented 4 years ago

@souvikmaji Thanks for working on this PR, You can also work on open new issue/feature relevant to this repo