search

patil-ashutosh / go-regex-utility

A curated list of golang applications using regex
MIT License
3 stars 8 forks source link

Add ipv6 validation #28

Closed suramrit closed 4 years ago

suramrit commented 4 years ago

This pull requests addresses the following feature:

👀 Seeking design approach from the repo contributors.

[WIP] 🔧 golinter criteria fail for this current work due to the nature of all the edge cases that need to be considered for ipv6 which add to the size of the function definition 🤔 Proposed workaround - relax function size and line size to accommodate the edge cases

patil-ashutosh commented 4 years ago

@suramrit This is great! Thank your for raising your pull request.

patil-ashutosh commented 4 years ago

This pull requests addresses the following feature:

* ipv6 validation  and test coverage for ipv6 addressing

👀 Seeking design approach from the repo contributors.

[WIP] 🔧 golinter criteria fail for this current work due to the nature of all the edge cases that need to be considered for ipv6 which add to the size of the function definition 🤔 Proposed workaround - relax function size and line size to accommodate the edge cases

@suramrit Thanks for pointing this out, we can relax function size and line size to accommodate the edge cases. But I think you can fix golinter comment in ipv6Validation_test.go file (line number 63). please let me know if you need any help

suramrit commented 4 years ago

Thanks for the feedback! 😊 @patil-ashutosh . I will fix the _test file as you mentioned. I also have another approach where I just loop through the different patterns, that could reduce the function definition. I'll push these changes today.

patil-ashutosh commented 4 years ago

@suramrit Thanks for working on this. You can also work on open new issue/feature relevant to this repo