Open patilsnehal opened 9 years ago
nesquena
commented
9 years ago Can you please update the GIF ASAP? And also provide more information on the issue so you can fix the bug with user information as well. Since you've completed most of the assignment, I don't want to withdraw you yet but please complete the assignment ASAP.
patilsnehal
commented
9 years ago Hey Nathan,
Yeah, I wanted to fix it, however thought I might be running out of time and was feeling too slugish and tired with the medication. Hence, uploaded whatever I had. I will try to fix it today. I know its a small bug somewhere.
I am getting null pointer assignment for the username when I click on the image. I think I am not handling intent properly. Its a error while loading profile image. I need to debug that part. Also, somehow I am not able to get User JSON too. I dont get success or failure for user info. Hence, wondering what might be wrong there. I need to take a look at the api and see if I am using query params properly or not. I will take a look at it.
I am sorry for incomplete assignment, however, my health just didnt allow me to do much on it.
Snehal
On Wed, Oct 1, 2014 at 12:22 AM, Nathan Esquenazi notifications@github.com wrote:
Can you please update the GIF ASAP? And also provide more information on the issue so you can fix the bug with user information as well. Since you've completed most of the assignment, I don't want to withdraw you yet but please complete the assignment ASAP.
— Reply to this email directly or view it on GitHub https://github.com/patilsnehal/AndroidBootCampProjects/issues/6#issuecomment-57427738 .
Snehal
nesquena
commented
9 years ago Some hints to help out:
I am getting null pointer assignment for the username when I click on the image.
Capitalization issue: https://github.com/patilsnehal/AndroidBootCampProjects/blob/master/TwitterClientApp/SimpleTwitterClient/src/com/codepath/apps/basictwitter/TweetArrayAdapter.java#L67 VS https://github.com/patilsnehal/AndroidBootCampProjects/blob/master/TwitterClientApp/SimpleTwitterClient/src/com/codepath/apps/basictwitter/ProfileActivity.java#L31 (not same capitalization)
Also, somehow I am not able to get User JSON too. I dont get success or failure for user info. Hence, wondering what might be wrong there.
Get rid of the trailing question mark here: https://github.com/patilsnehal/AndroidBootCampProjects/blob/master/TwitterClientApp/SimpleTwitterClient/src/com/codepath/apps/basictwitter/TwitterClient.java#L128
Bonus: https://github.com/patilsnehal/AndroidBootCampProjects/blob/master/TwitterClientApp/SimpleTwitterClient/res/layout/activity_profile.xml#L16 doesn't match id https://github.com/patilsnehal/AndroidBootCampProjects/blob/master/TwitterClientApp/SimpleTwitterClient/src/com/codepath/apps/basictwitter/ProfileActivity.java#L48
Can you apply those fixes and see if you can complete with those hints?
patilsnehal
commented
9 years ago Hello Nathan,
Thank you so much for the help. I wasnt still feeling better hence couldnt work on it earlier.
I fixed the bugs now and it seems to be working okie now :) Thank you so much again ! @thecodepath @nesquena.
Snehal
nesquena
commented
9 years ago Glad you got it working. Hope you feel better too. see you next week.
My Twitter Client App is incomplete :( I couldnt fix the bug regarding user info on the user profile page. HOwever, I finished user profile, fragments and mentions timeline etc. Please review @thecodepath @nesquena.