search

patjak / facetimehd

Reverse engineered Linux driver for the FacetimeHD (Broadcom 1570) PCIe webcam
GNU General Public License v2.0
1.36k stars 161 forks source link

Fixing OSX firmware dump script for OSX 10.11.2 #22

Closed JPtheJP closed 8 years ago

JPtheJP commented 8 years ago

Use of md5 -r instead of md5sum (absent from vanilla OS X) Proper OS_HASH Exact path for IN variable to work with OS X 10.11.2 I think the default script should work without modification. For now those changes are listed in the Getting Started wiki.

Bear with me, this is my github learning path, and this is my first pull request.

miekg commented 8 years ago

This breaks the script on Linux.

Interestingly though, I have the same hash for the AppleCameraInterface file

patjak commented 8 years ago

The idea is to run the script from Linux. That way we can extract the firmware from both the osx and windows version.

JPtheJP commented 8 years ago

Well, then should I rename the script to have an OS X specific one, and a Linix specific one?

As it is, the script is broken on OS X (md5sum missing). I know some of you have wiped OS X and kept no traces of it. I also know a lot of users either keep an external HD with OS X on it, and the easiest path (for now) is to boot OS X, run the script there and go back to Linux.

OK, reject the pull request please. I'll make a specific file for OSX without touching that existing one.