patjak / facetimehd

Reverse engineered Linux driver for the FacetimeHD (Broadcom 1570) PCIe webcam
GNU General Public License v2.0
1.36k stars 161 forks source link

Make Error on Kernel 5.7 #222

Closed gedster314 closed 4 years ago

gedster314 commented 4 years ago

I know it's a new kernel release, not expecting a quick response. Just throwing it out there as an fyi. This on PopOS 20.04 on a 2014 MacBookAir. The current PopOS kernel and the Ubuntu mainline kernel 5.6.15 work fine when I follow the instructions. The Ubuntu Mainline 5.7 kernel does not. Here is the make outpout.

make -C /lib/modules/5.7.0-050700-generic/build M=/home/gary/tmp/bcwc_pcie modules make[1]: Entering directory '/usr/src/linux-headers-5.7.0-050700-generic' CC [M] /home/gary/tmp/bcwc_pcie/fthd_ddr.o CC [M] /home/gary/tmp/bcwc_pcie/fthd_hw.o CC [M] /home/gary/tmp/bcwc_pcie/fthd_drv.o CC [M] /home/gary/tmp/bcwc_pcie/fthd_ringbuf.o CC [M] /home/gary/tmp/bcwc_pcie/fthd_isp.o CC [M] /home/gary/tmp/bcwc_pcie/fthd_v4l2.o /home/gary/tmp/bcwc_pcie/fthd_v4l2.c: In function ‘fthd_v4l2_register’: /home/gary/tmp/bcwc_pcie/fthd_v4l2.c:732:36: error: ‘VFL_TYPE_GRABBER’ undeclared (first use in this function); did you mean ‘VFL_TYPE_SUBDEV’? 732 | ret = video_register_device(vdev, VFL_TYPE_GRABBER, -1); | ^~~~ | VFL_TYPE_SUBDEV /home/gary/tmp/bcwc_pcie/fthd_v4l2.c:732:36: note: each undeclared identifier is reported only once for each function it appears in make[2]: [scripts/Makefile.build:267: /home/gary/tmp/bcwc_pcie/fthd_v4l2.o] Error 1 make[1]: [Makefile:1729: /home/gary/tmp/bcwc_pcie] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-5.7.0-050700-generic' make: *** [Makefile:12: all] Error 2

patjak commented 4 years ago

Hi, this is fixed in 82626d4892eeb9eb704538bf0dc49a00725ff451